Deprecate unused initializers #4657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmac
force-pushed
the
issue-4093
branch
2 times, most recently
from
ed6e092 to
1ab73b4
Compare
|
👍 |
locks
requested changes
Nov 20, 2016
| @@ -10,5 +10,5 @@ import Ember from 'ember'; | |||
| export default { | |||
| name: 'data-adapter', | |||
| before: 'store', | |||
| initialize: Ember.K | |||
|
rebased @locks |
bmac
commented
Nov 22, 2016
|
|
||
|
|
||
|
|
||
| let deprecatedInitializerNames = ['data-adapter', 'injectStore', 'transforms', 'store']; |
There was a problem hiding this comment.
store should not be included in this list.
There was a problem hiding this comment.
Nevermind. This code is correct. I got store confused with the ember-data initializer.
|
I was given feedback that this should go through an RFC so there is an official document on why this has been deprecated. |
This was referenced Dec 12, 2016
Merged
Open
locks
approved these changes
Jan 5, 2017
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4093