Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] empty records in the process of being requested should be in the empty state #5522

Closed
wagenet opened this issue Jul 9, 2018 · 5 comments
Closed

[FEAT] empty records in the process of being requested should be in the empty state #5522

wagenet opened this issue Jul 9, 2018 · 5 comments
Assignees
@runspired
Labels
feature-suggestion

Comments

@wagenet
Copy link
Member

wagenet commented Jul 9, 2018 •
edited by runspired
Loading

Record that have never been fulfilled (e.g. empty) but which transition to a loading state should also remain empty until the loading state is resolved. To accomplish this, a deprecation will need to be created for when isEmpty returns false but isLoading is true.

Original issue that surfaced this:

Commit 3b7b5e7 causes the regression.

See also #5517.
@wagenet
Copy link
Member Author

wagenet commented Jul 12, 2018

@runspired ping

runspired added a commit that referenced this issue Jul 20, 2018
@runspired
adds test for #5522 isEmpty issue
fd6bf80
@runspired runspired added the Bug label Jul 21, 2018
runspired added a commit that referenced this issue Jul 23, 2018
@runspired
[BUGFIX] fix and tests for belongs-to proxy not properly updating (#5533
39c8238 
)

* adds failing tests for #5511 and #5517

* add a test for #5525 that suspiciously passes

* adds test for #5522 isEmpty issue

* run prettier

* fix issue with proxy

* upgrade test for potential issue with create, still passes

* fix emberobserver issue for missing data member in payloads
@runspired runspired changed the title REGRESSION: empty records in the process of being requested aren't flagged as being in the empty state empty records in the process of being requested aren't flagged as being in the empty state Aug 9, 2018
@runspired
Copy link
Contributor

The bug that this resulted in was fixed in #5562 however, we still do not consider isLoading records to also be isEmpty when we likely should. Since that has been the case since forever, it will require a deprecation lifecycle to change. Converting this ticket to track that.

@runspired runspired added Feature and removed Bug labels Aug 9, 2018
@runspired runspired changed the title empty records in the process of being requested aren't flagged as being in the empty state [FEAT] empty records in the process of being requested should be in the empty state Aug 9, 2018
@wagenet
Copy link
Member Author

wagenet commented Aug 9, 2018

@runspired thanks!

@wagenet
Copy link
Member Author

wagenet commented Aug 10, 2018

@runspired I just verified that #5562 fixes the exact issue that I ran into.

@runspired
Copy link
Contributor

Closing in favor of RFC (which needs to be written, but details are here): emberjs/rfcs#359

NullVoxPopuli pushed a commit to NullVoxPopuli/data that referenced this issue Sep 8, 2018
@runspired @NullVoxPopuli
[BUGFIX] fix and tests for belongs-to proxy not properly updating (em…
bbda146 
…berjs#5533)

* adds failing tests for emberjs#5511 and emberjs#5517

* add a test for emberjs#5525 that suspiciously passes

* adds test for emberjs#5522 isEmpty issue

* run prettier

* fix issue with proxy

* upgrade test for potential issue with create, still passes

* fix emberobserver issue for missing data member in payloads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@runspired runspired

Labels
feature-suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wagenet @runspired