-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Rollup -private
as part of prepublish
#6051
Labels
Comments
Not sure if this is related, but with
|
#6180 resolves the warnings and restores rollup but we still need to do the pre-publish |
runspired
changed the title
Restore rollup step of
Rollup Sep 27, 2019
-private
as part of prepublish-private
as part of prepublish
runspired
changed the title
Rollup
[FEAT] Rollup Sep 27, 2019
-private
as part of prepublish-private
as part of prepublish
@dcyriller is going to look into this as part of better preparing ember-data for embroider |
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
EmberData uses
Rollup
to merge all of our-private
directories into single modules.-private
represents a single module organized as many modules for maintenance ease.This benefits us in three ways:
parse
time by having a single module instead of many modules (mostly via a reduction in the number of scopes and closures involved).It also comes with a few drawbacks:
We should make all of the packages rollup their
-private
directories as aprepublish
step such that consuming applications get a single-private
module when they install one of our packages and don't pay the cost of rollup at all.This will also make things play nicer with
embroider
becauseembroider
will not need to run our build step before being able to construct the graph correctly, as our modules will be in the correct form by the time embroider sees them in consuming applications.The rollup output should be an ES Module with as minimal transpilation done as possible so that we can respect the
target
of consuming applications. Getting the babel config right such that EmberData's needs and consuming app targets are both respected will likely be the more difficult bit here.The text was updated successfully, but these errors were encountered: