Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: @ember-data/store as v2-lite addon #8285

Merged
merged 9 commits into from
Dec 8, 2022
Merged

feat: @ember-data/store as v2-lite addon #8285

merged 9 commits into from
Dec 8, 2022

Conversation

runspired
Copy link
Contributor

Converts @ember-data/store rollup step to pre-publish. Currently still ships as a v1-addon but with a modified addon tree pulling from the pre-built dist.

y3NE6rr

@runspired runspired added 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature 5.0 Roadmap ci-assetsize Activates Asset Size Checks in CI labels Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Asset Size Report for 8e014f4

Modern Builds

🛑 The size of the library EmberData has increased by +2.46 KB (+269.0 B compressed) which exceeds the failure threshold of 75 bytes.

Warnings

⚠️ The uncompressed size of the package @ember-data/store has increased by +1.22 KB.
⚠️ The uncompressed size of the package @ember-data/tracking has increased by +1.24 KB.

Changeset


EmberData 167.46 KB +2.46 KB (35.31 KB +269.0 B compressed)
    @ember-data/store 43.95 KB +1.22 KB (9.27 KB +133.43 B compressed)
        @ember-data/store/-private 2.03 KB -39.71 KB (437.3 B -4.25 KB compressed)
        @ember-data/store/index 883.0 B -139.0 B (186.18 B -14.87 B compressed)
        @ember-data/store/index-b8734028 41.06 KB +41.06 KB (8.66 KB +4.39 KB compressed)
    @ember-data/tracking 1.24 KB +1.24 KB (267.14 B +135.57 B compressed)
        @ember-data/tracking/-private 839.0 B +839.0 B (176.89 B +89.77 B compressed)
        @ember-data/tracking/index 428.0 B +428.0 B (90.24 B +45.8 B compressed)

Full Asset Analysis (Modern)

Asset Size Report
=================


Library: EmberData
┌────────────┬─────────────┐
│  (index)   │   Values    │
├────────────┼─────────────┤
│   bytes    │ '167.46 KB' │
│ compressed │ '35.31 KB'  │
│  packages  │      9      │
│  modules   │     47      │
└────────────┴─────────────┘

Package: @ember-data/model
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '44.68 KB' │
│  compressed  │ '9.42 KB'  │
│ % Of Library │   '26.7'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/model/-private                        | 44.21 KB  | 9.32 KB    | 98.9          | 26.4
	@ember-data/model/index                           | 486.00 B  | 102.47 B   | 1.1           | 0.3

Package: @ember-data/store
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '43.95 KB' │
│  compressed  │ '9.27 KB'  │
│ % Of Library │   '26.2'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/store/index-b8734028                  | 41.06 KB  | 8.66 KB    | 93.4          | 24.5
	@ember-data/store/-private                        | 2.03 KB   | 437.30 B   | 4.6           | 1.2
	@ember-data/store/index                           | 883.00 B  | 186.18 B   | 2.0           | 0.5

Package: @ember-data/record-data
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '23.33 KB' │
│  compressed  │ '4.92 KB'  │
│ % Of Library │   '13.9'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/record-data/-private                  | 23.33 KB  | 4.92 KB    | 100.0         | 13.9

Package: @ember-data/serializer
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '20.32 KB' │
│  compressed  │ '4.28 KB'  │
│ % Of Library │   '12.1'   │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/serializer/json                       | 7.36 KB   | 1.55 KB    | 36.2          | 4.4
	@ember-data/serializer/-private                   | 5.50 KB   | 1.16 KB    | 27.1          | 3.3
	@ember-data/serializer/json-api                   | 3.79 KB   | 818.30 B   | 18.7          | 2.3
	@ember-data/serializer/rest                       | 2.87 KB   | 618.63 B   | 14.1          | 1.7
	@ember-data/serializer/index                      | 611.00 B  | 128.82 B   | 2.9           | 0.4
	@ember-data/serializer/transform                  | 215.00 B  | 45.33 B    | 1.0           | 0.1

Package: @ember-data/adapter
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '15.94 KB' │
│  compressed  │ '3.36 KB'  │
│ % Of Library │   '9.5'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/adapter/rest                          | 7.87 KB   | 1.66 KB    | 49.4          | 4.7
	@ember-data/adapter/-private                      | 3.80 KB   | 819.78 B   | 23.8          | 2.3
	@ember-data/adapter/error                         | 1.82 KB   | 393.44 B   | 11.4          | 1.1
	@ember-data/adapter/index                         | 1.41 KB   | 304.88 B   | 8.9           | 0.8
	@ember-data/adapter/json-api                      | 1.03 KB   | 223.29 B   | 6.5           | 0.6

Package: ember-data
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '8.30 KB' │
│  compressed  │ '1.75 KB' │
│ % Of Library │   '5.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-data/index                                  | 1.96 KB   | 424.22 B   | 23.7          | 1.2
	ember-data/-private                               | 1.53 KB   | 331.24 B   | 18.5          | 0.9
	ember-data/adapters/errors                        | 1.19 KB   | 256.60 B   | 14.3          | 0.7
	ember-data/setup-container                        | 368.00 B  | 77.59 B    | 4.3           | 0.2
	ember-data/relationships                          | 318.00 B  | 67.05 B    | 3.7           | 0.2
	ember-data/serializers/embedded-records-mixin     | 274.00 B  | 57.77 B    | 3.2           | 0.2
	ember-data/serializers/json-api                   | 251.00 B  | 52.92 B    | 3.0           | 0.1
	ember-data/adapters/json-api                      | 245.00 B  | 51.65 B    | 2.9           | 0.1
	ember-data/serializers/json                       | 243.00 B  | 51.23 B    | 2.9           | 0.1
	ember-data/serializers/rest                       | 243.00 B  | 51.23 B    | 2.9           | 0.1
	ember-data/transform                              | 241.00 B  | 50.81 B    | 2.8           | 0.1
	ember-data/adapters/rest                          | 237.00 B  | 49.97 B    | 2.8           | 0.1
	ember-data/serializer                             | 232.00 B  | 48.91 B    | 2.7           | 0.1
	ember-data/adapter                                | 226.00 B  | 47.65 B    | 2.7           | 0.1
	ember-data/model                                  | 222.00 B  | 46.80 B    | 2.6           | 0.1
	ember-data/store                                  | 222.00 B  | 46.80 B    | 2.6           | 0.1
	ember-data/attr                                   | 218.00 B  | 45.96 B    | 2.6           | 0.1
	ember-data/version                                | 162.00 B  | 34.15 B    | 1.9           | 0.1

Package: ember-inflector
┌──────────────┬───────────┐
│   (index)    │  Values   │
├──────────────┼───────────┤
│    bytes     │ '6.69 KB' │
│  compressed  │ '1.41 KB' │
│ % Of Library │   '4.0'   │
└──────────────┴───────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	ember-inflector/lib/system/inflector              | 2.99 KB   | 644.98 B   | 44.7          | 1.8
	ember-inflector/lib/system/inflections            | 1.59 KB   | 343.05 B   | 23.7          | 0.9
	ember-inflector/lib/system                        | 471.00 B  | 99.31 B    | 6.9           | 0.3
	ember-inflector/index                             | 379.00 B  | 79.91 B    | 5.5           | 0.2
	ember-inflector/lib/helpers/pluralize             | 369.00 B  | 77.80 B    | 5.4           | 0.2
	ember-inflector/lib/utils/make-helper             | 332.00 B  | 70.00 B    | 4.8           | 0.2
	ember-inflector/lib/system/string                 | 318.00 B  | 67.05 B    | 4.6           | 0.2
	ember-inflector/lib/helpers/singularize           | 296.00 B  | 62.41 B    | 4.3           | 0.2

Package: @ember-data/debug
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '3.02 KB'  │
│  compressed  │ '651.10 B' │
│ % Of Library │   '1.8'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/debug/index                           | 2.27 KB   | 490.85 B   | 75.4          | 1.4
	@ember-data/debug/setup                           | 760.00 B  | 160.24 B   | 24.6          | 0.4

Package: @ember-data/tracking
┌──────────────┬────────────┐
│   (index)    │   Values   │
├──────────────┼────────────┤
│    bytes     │ '1.24 KB'  │
│  compressed  │ '267.14 B' │
│ % Of Library │   '0.7'    │
└──────────────┴────────────┘
	Module                                            | Bytes     | Compressed | % of Package  | % Of Library
	-----------------------------------------------------------------------------------------------------
	@ember-data/tracking/-private                     | 839.00 B  | 176.89 B   | 66.2          | 0.5
	@ember-data/tracking/index                        | 428.00 B  | 90.24 B    | 33.8          | 0.2

@runspired runspired merged commit fd6d097 into master Dec 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the v2-addons branch December 8, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 Roadmap ci-assetsize Activates Asset Size Checks in CI 🎯 canary PR is targeting canary (default) 🏷️ feat This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant