Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LegacyHandler in 4.12 providing frozen options to Adapters #8578

Closed
kiosion opened this issue Apr 19, 2023 · 0 comments
Closed

LegacyHandler in 4.12 providing frozen options to Adapters #8578

kiosion opened this issue Apr 19, 2023 · 0 comments
Labels
🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance

Comments

@kiosion
Copy link
Contributor

kiosion commented Apr 19, 2023

Reproduction

I've put up a PR with a failing test case, and what I think could work as a fix - #8576

Description

In 4.12, the options LegacyHandler passes on to Adapters from requests are frozen, making attempts to modify them within query/queryRecord/urlForQuery/etc methods throw TypeErrors. Ideally, these would still be mutable, as they were in previous releases of ember-data.

Versions

├─ @ember-data/adapter@4.12.0
├─ @ember-data/canary-features@4.11.3
├─ @ember-data/debug@4.12.0
├─ @ember-data/graph@4.12.0
├─ @ember-data/json-api@4.12.0
├─ @ember-data/legacy-compat@4.12.0
├─ @ember-data/model@4.12.0
├─ @ember-data/private-build-infra@4.12.0
├─ @ember-data/record-data@4.11.3
│  └─ @ember-data/private-build-infra@4.11.3
├─ @ember-data/request@4.12.0
├─ @ember-data/rfc395-data@0.0.4
├─ @ember-data/serializer@4.12.0
├─ @ember-data/store@4.12.0
├─ @ember-data/tracking@4.12.0
└─ ember-data@4.12.0
@runspired runspired added Bug lts-4-12 Long Term LTS Maintenance labels May 6, 2023
@runspired runspired added 🏷️ bug This PR primarily fixes a reported issue and removed Bug labels Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bug This PR primarily fixes a reported issue lts-4-12 Long Term LTS Maintenance
Projects
None yet
Development

No branches or pull requests

2 participants