-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LegacyHandler should provide unfrozen options to Adapters #8576
Merged
runspired
merged 5 commits into
emberjs:main
from
kiosion:legacy-handler-mutable-options
May 6, 2023
Merged
fix: LegacyHandler should provide unfrozen options to Adapters #8576
runspired
merged 5 commits into
emberjs:main
from
kiosion:legacy-handler-mutable-options
May 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiosion
force-pushed
the
legacy-handler-mutable-options
branch
from
April 19, 2023 15:48
561b688
to
bcfe010
Compare
runspired
changed the title
LegacyHandler providing frozen options to Adapters
fix: LegacyHandler should provide unfrozen options to Adapters
May 6, 2023
runspired
added a commit
that referenced
this pull request
May 24, 2023
#8576) --------- Co-authored-by: Chris Thoburn <runspired@gmail.com>
Thanks. I'm also experiencing this from: urlForQuery(query) {
let url = super.urlForQuery(...arguments);
if (query.something) {
url = `${url}/${query.something}`;
delete query.something;
}
return url;
} this.store.query('foo', {
something: 'abc'
}); The actual URL used will be But it should be |
runspired
added a commit
that referenced
this pull request
Jun 10, 2023
#8576) --------- Co-authored-by: Chris Thoburn <runspired@gmail.com>
runspired
added a commit
that referenced
this pull request
Jun 10, 2023
* fix: restore Store extends EmberObject :( (#8594) * fix: restore Store extends EmberObject :( * fix EmberObject bs * fix: LegacyHandler should provide unfrozen options to Adapters (resolves #8576) --------- Co-authored-by: Chris Thoburn <runspired@gmail.com> * fix: dont share promise cache for all fields (#8597) * fix: docs generation should maintain a stable relative path (#8598) * docs: fix forgotten references to FetchManager (#8601) * Avoid unnecessary identity notification when record is saved (#8566) * Add failing test * Ignore JetBrains IDE files * Revise failing test * Call setRecordId only for new records * Add (failing) test for updated id from server * update test * error when appropriate, thread context to give cache responsibility * fix lint --------- Co-authored-by: Chris Thoburn <runspired@gmail.com> * fix backport of identity notification fix * There are cases where payload is an object, and normalizeErrorRespons… (#8621) * There are cases where payload is an object, and normalizeErrorResponse ends up returning [object Object] for "detail" * Add comment about JSON.stringify * Update rest.ts --------- Co-authored-by: Maxim <hi@kio.dev> Co-authored-by: Robby Morgan <robby.morgan@yahoo.com> Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue with the LegacyHandler in 4.12 - The StoreRequestContext obj passed to legacy Adapters is frozen, causing issues when modifying request params, i.e., modifying the
query
param within an Adapter'squery
orurlForQuery
methods. I've added a failing test case as a reproduction of how I ran into this issue.Notes for the release