Various Backported Fixes for 4.12 LTS #8618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
runspired
commented
May 24, 2023
•
runspired
commented
- fix: restore Store extends EmberObject (fix: restore Store extends EmberObject :( #8594)
- fix: LegacyHandler should provide unfrozen options to Adapters (fix: LegacyHandler should provide unfrozen options to Adapters #8576)
- fix: dont share promise cache for all fields (fix: dont share promise cache for all fields #8597)
- fix: docs generation should maintain a stable relative path (fix: docs generation should maintain a stable relative path #8598)
- docs: fix forgotten references to FetchManager (docs: fix forgotten references to FetchManager #8601)
- Avoid unnecessary identity notification when record is saved (Avoid unnecessary identity notification when record is saved #8566)
- fix: normalizeErrorResponse should be resilient to non-string details (fix: normalizeErrorResponse should be resilient to non-string details #8621)
runspired
added
🏷️ bug
runspired
changed the title
* fix: restore Store extends EmberObject :( * fix EmberObject bs
#8576) --------- Co-authored-by: Chris Thoburn <runspired@gmail.com>
* Add failing test * Ignore JetBrains IDE files * Revise failing test * Call setRecordId only for new records * Add (failing) test for updated id from server * update test * error when appropriate, thread context to give cache responsibility * fix lint --------- Co-authored-by: Chris Thoburn <runspired@gmail.com>
#8621) * There are cases where payload is an object, and normalizeErrorResponse ends up returning [object Object] for "detail" * Add comment about JSON.stringify * Update rest.ts
3 tasks
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.