Make version check for Ember.js strict #2965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `Ember.VERSION` contains some version suffix (such as '1.11.0.72d2409e'), This check will reject this version of Ember unexpectedly.
|
👍 |
wecc
added a commit
that referenced
this pull request
Apr 1, 2015
Make version check for Ember.js strict
|
Thanks @tricknotes! |
|
@rwjblue any chance we could get this brought into the ember-data beta channel on https://github.com/components/ember-data ? Right now, using the release/beta/canary streams of ember w/ ember-data doesn't work, due to the bug that this PR fixes |
mike-north
pushed a commit
to mike-north/ember-data
that referenced
this pull request
Apr 11, 2015
|
It should already be in the ember-data canary builds. |
|
I think the beta.17 should be out pretty soon, so maybe not worth doing a beta.16.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Ember.VERSIONcontains some version suffix (such as '1.11.0.72d2409e'),This check will reject this version of Ember unexpectedly.