Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented the Model's rolledBack event #3046

Merged
merged 1 commit into from
May 6, 2015
Merged

Conversation

lolmaus
Copy link
Contributor

@lolmaus lolmaus commented May 6, 2015

No description provided.

@@ -499,6 +499,13 @@ var Model = Ember.Object.extend(Ember.Evented, {
becameError: Ember.K,

/**
Fired when the record is rolled back.

@event becameError
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@event becameError -> @event rolledBack

@lolmaus
Copy link
Contributor Author

lolmaus commented May 6, 2015

@bmac, updated.

@bmac
Copy link
Member

bmac commented May 6, 2015

Thanks! Do you mind squashing pr down to 1 commit?

Documented the Model's `rolledBack` event -- fixup
@lolmaus
Copy link
Contributor Author

lolmaus commented May 6, 2015

Done.

bmac added a commit that referenced this pull request May 6, 2015
Documented the Model's `rolledBack` event
@bmac bmac merged commit 51bac6a into emberjs:master May 6, 2015
@bmac
Copy link
Member

bmac commented May 6, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants