-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lookup the store using store:application instead of store:main #3136
Conversation
Can @rwjblue or @stefanpenner review? |
This simplifes the process of registering the store when a user creates a custom one. This change also fixes deprecations warning introduces in Ember 1.12. The store service is now injected as a instanceInitializer.
Looks good to me. We should probably update any docs that reference 'app/store.js' in favor of 'app/stores/application.js' (both here and in the guides). |
@rwjblue I searched through the guides and the API docs and couldn't find any instance of 'app/store.js' (which should have already given a deprecation message).
|
Lookup the store using store:application instead of store:main
emberjs/data#3136 to use store:application now
This simplifes the process of registering the store when a user
creates a custom one. This change also fixes deprecations warning
introduces in Ember 1.12. The store service is now injected as a
instanceInitializer.