Use string model names in debug adapter #3203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Legacy Ember.js < 1.13 support | ||
| let containerKey = klass._debugContainerKey; | ||
| if (containerKey) { | ||
| modelName = containerKey.match(/model:(.*)/)[1]; |
There was a problem hiding this comment.
if there is no match won't this return null, and thus error out when trying to use [1] to access a property on null?
There was a problem hiding this comment.
Yes, but I couldn't think of a reason why it wouldn't match. Do you think there's a case where the model factory's container key doesn't contain model:?
There was a problem hiding this comment.
I added a check just in case.
teddyzeenny
force-pushed
the
debug-adapter
branch
from
23d30fd to
41bc413
Compare
| // Ideally this should always get passed a string. | ||
|
|
||
| var modelName = typeof modelNameOrFactory === 'string' ? modelNameOrFactory : modelNameOrFactory.modelName; | ||
| getRecords: function(klass, modelName) { |
There was a problem hiding this comment.
i think we use modelClass for this case
teddyzeenny
force-pushed
the
debug-adapter
branch
3 times, most recently
from
6bb3cc4 to
d7d3a88
Compare
igorT
added a commit
that referenced
this pull request
Jun 5, 2015
Use string model names in debug adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to emberjs/ember.js#11346