-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
serialize:true takes priority over the OneToMany check for relationships #3214
Conversation
@property _mustSerialize | ||
@private | ||
*/ | ||
_mustSerialize: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense as a flag, it's a value that changes for each key, so needs to be a function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did'nt thought about that, definitely I will remove that.
@sly7-7 we should implement |
@igorT I think I understand, I don't know when you want this, but I won't be able to do before tomorrow evening (trip today, soccer tomorrow). If it's not to late I'm happy to take that. |
No rush, enjoy the game |
@igorT Ping ? |
Seems to fail on Travis due to jshint |
@igorT I'm confused, I can't reproduce the jshint error locally. I just rebase and force push... let's see whan happen |
@igorT It's ready if you don't have any other (welcome) advices :) |
@sly7-7 I think we talked about moving the
to be next to the canSerialize line right? |
serialize:true takes priority over the OneToMany check for relationships
Thanks! |
Fixes #3189
Apologize in advance for my frenglished documentation
cc/ @igorT