Pass _internalModel into a record when it is created #3262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any way we could have a test please? |
|
Will do |
bmac
force-pushed
the
create-internal-model
branch
from
6406f1f to
399f88f
Compare
|
I added a test. @igorT let me know if there is a better way to test this without directly asserting around internals. |
|
|
||
| init: function() { | ||
| this._super.apply(this, arguments); | ||
| ok(this._internalModel); |
There was a problem hiding this comment.
ok(this.get('name')) is the thing we actually care about
bmac
force-pushed
the
create-internal-model
branch
from
399f88f to
7bd5993
Compare
igorT
added a commit
that referenced
this pull request
Jun 8, 2015
Pass _internalModel into a record when it is created
|
cc @fivetanley for beta.19.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3255.