Implement RFC 57 - Reference Unification #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,77 @@ | |||
| import Ember from 'ember'; | |||
| // FIXME doesn't work an Model is undefined | |||
| // import Model from '../model'; | |||
There was a problem hiding this comment.
Probably due to circular dependencies which are not supported right now
pangratz
changed the title
|
status on this? |
pangratz
changed the title
|
@pangratz do you mind rebasing this pr and adding feature flags so this can be merged? |
|
@bmac done... |
bmac
added a commit
that referenced
this pull request
Dec 15, 2015
Implement RFC 57 - Reference Unification
|
🎉 |
|
🎈 🎆 🌟 I thought this was still pending approval from the core team (RFC-thread). Then suddenly, as gift from the heavens, it's landing in |
This was referenced Jan 2, 2016
|
Wow. I was just catching up on some things and came across this (and the RFC). 👍. This will definitely help us out in our app. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to RFC