-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP beta] Remove Store deprecations #3532
Conversation
Failing on emberchannel beta, investigating... |
This seem to cause stuff like this to fail: author.set('posts', store.peekAll('post')); ...because We can use ping @stefanpenner |
// We are passed a query instead of an id. | ||
if (Ember.typeOf(id) === 'object') { | ||
Ember.assert('Calling store.find() with a query object is no longer supported. Use store.query() instead.'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of keeping asserts for the old store.find
usages so people copy and pasting old code get a helpful error message.
@wecc did you ever make any progress on the |
@bmac no, I'm unsure on how to continue |
Lets give Ember Data an internal helper function called |
Works for me! I'll get to it. |
@bmac should be ready to 🚢 |
[CLEANUP beta] Remove Store deprecations
💃 |
❤️ |
Contribute to open source, they said.
It'll be fun, they said.
Closes #3223