-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JSONSerializer to pass through payload.included
#3550
Conversation
The tests pass locally for me but I am sure my test is not actually running!! is there some way to isolate just this test? or do integration tests need separate command? |
b6c931f
to
3a2a0d9
Compare
If you use |
@fivetanley ok thanks, got it! My tests are not running with |
It looks like it is, at least on travis: https://travis-ci.org/emberjs/data/builds/71138302#L552 |
They run with as a test, I deleted the entire
surely that should have dropped by at least 100.. Anyway, I can get by using |
npm test doesn't do a full build, so you're likely getting an old build. we should probably fix that. to re-run with npm test, use |
3a2a0d9
to
672e47e
Compare
ok, np, tests are passing now. |
Would love for embedded records to not be broken 👍 |
documentHash.data = data; | ||
documentHash.included = included; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
included
could be undefined
here, we should add a check
672e47e
to
ab614cc
Compare
@wecc fixed, added isolating test |
Fix JSONSerializer to pass through `payload.included`
Respect an underlying JSON-API payload's
included
property.Prior to this, records extracted via
EmbeddedRecordsMixin
were being truncated and forgotten.See #3549