[BUGFIX beta] Initializer/Instance Initializer Deprecations. #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of 2.1.0 the ApplicationInstance instance that we receive in an instance initializer has a `lookup` method on it directly. This is new public API that replaces `appInstance.container.lookup` as of 2.1.0.
As of Ember 2.1.0 initializers should receive a single argument (the application), and that object has most of the public API of the previous first argument (`register`, `optionsForType`, etc). To support older initializers, any initializer written that expects 2 arguments receives a deprecation. This fixes the argument arity to prevent deprecations.
rwjblue
force-pushed
the
fix-initializer-deprecations
branch
from
a0fdeea to
4e7fb74
Compare
|
Rebased, should pass Travis for all three branches now. |
| @@ -22,7 +31,7 @@ export default function initializeStore(registry, application) { | |||
| registry.register('serializer:-json-api', JSONAPISerializer); | |||
|
|
|||
|
|
|||
| if (!registry.has('service:store')) { | |||
| if (has(registry, 'service:store')) { | |||
There was a problem hiding this comment.
Looks like this change if statement lost the !.
In the new initializer system intection has been renamed to inject and optionsForType has been renamed to registerOptionsForType.
[BUGFIX beta] Don't use old method names with the new injection system.
|
@bmac - Thanks for fixing this up for me! |
bmac
added a commit
that referenced
this pull request
Aug 20, 2015
[BUGFIX beta] Initializer/Instance Initializer Deprecations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.