[BUGFIX release-1-13] Ensure that service:store
is cleared before regsitering.
#3690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In globals apps, calling
App.reset()
will cause these initializers to be ran multiple times for eachcontainer
/registry
instance. This means that whenApp.reset()
is called,service:store
is already registered AND resolved, throwing the following error:The fix is to
unregister
beforeregister
ing again.Fixes emberjs/ember.js#10310.
Please note, this is already a non-issue in 2.0.0 (aka release branch). This PR is targeting the
release-1-13
branch (which was branched from thev1.13.11
tag).