Remove Fixture Adapter #3717
Merged
Remove Fixture Adapter #3717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also remove this file? https://github.com/emberjs/data/blob/master/packages/ember-data/lib/adapters/fixture-adapter.js |
greyhwndz
force-pushed
the
remove-fixture-adapter-references
branch
from
4d9d3f1 to
188fb14
Compare
|
@bmac: Done. |
|
Oops, looks like the fixture adapter also needs to be emoved from this file: https://github.com/emberjs/data/blob/7b2c70d5e454a485eae4d64c7cdabfa020208b9d/packages/ember-data/lib/adapters.js |
greyhwndz
force-pushed
the
remove-fixture-adapter-references
branch
from
188fb14 to
60b7ae7
Compare
|
@bmac: Just finished removing the references to FixtureAdapter in lib/adapter.js |
fivetanley
added a commit
that referenced
this pull request
Aug 30, 2015
…nces Remove Fixture Adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bmac: Would be glad to hear some feedback regarding this PR. Thanks!