Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional statement that is always true #3844

Merged
merged 1 commit into from
Oct 16, 2015
Merged

Conversation

bmac
Copy link
Member

@bmac bmac commented Oct 13, 2015

Closes #3629

let response = adapter.handleResponse(
jqXHR.status,
parseResponseHeaders(jqXHR.getAllResponseHeaders()),
response || payload
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response || payload -> payload

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tchak
Copy link
Member

tchak commented Oct 15, 2015

@bmac LGTM except for the little adjustment I made in the comments

bmac added a commit that referenced this pull request Oct 16, 2015
Remove conditional statement that is always true
@bmac bmac merged commit 188efdd into emberjs:master Oct 16, 2015
@bmac bmac deleted the bug-3629 branch October 16, 2015 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants