Rely on internalModel.createSnapshot to set adapterOptions #3989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`internalModel.createSnapshot` already sets the `adapterOptions�` on the new snapshot the same way when `options` are provided.
fivetanley
added a commit
that referenced
this pull request
Dec 13, 2015
Rely on internalModel.createSnapshot to set adapterOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internalModel.createSnapshot already sets the
adapterOptionsonthe new snapshot the same way when
optionsare provided.Found this while working on #3976 and figured that it would make sense to try to keep the logic for creating the snapshot in one place.