Run the Ember Data initializer when Ember Data is loaded as an Ember … #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d as an Ember CLI addon.
bmac
force-pushed
the
run-initializer-as-addon
branch
from
cd83410 to
9ac62ad
Compare
|
👍 We can move the |
fivetanley
added a commit
that referenced
this pull request
Dec 16, 2015
Run the Ember Data initializer when Ember Data is loaded as an Ember …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…CLI addon.
I believe this fixes. http://discuss.emberjs.com/t/jsonapiadapter-not-recognized-findall-is-not-a-function/9307
In globals mode this code https://github.com/emberjs/data/blob/master/addon/-private/ember-initializer.js#L44-L80 registers the Ember initializers. However, it appears when Ember Data is loaded as an Ember CLI addon the
Ember.onLoadcallback is being called after Ember's initializers step has already completed.I suspect there is a better way of doing this. Possibly by ensuring https://github.com/emberjs/data/blob/master/addon/-private/ember-initializer.js#L44-L80 only gets added to the globals build.