Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Remove special logic for meta.descs in tests #4031

Merged
merged 1 commit into from
Dec 26, 2015
Merged

[CLEANUP] Remove special logic for meta.descs in tests #4031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions tests/unit/record-array-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,6 @@ test("stops updating when destroyed", function(assert) {
var store = createStore({
person: Person
});
// TODO remove once
// https://github.com/emberjs/ember.js/commit/c3f13e85a62069295965dd49ca487fe6ddba1188
// is on the release branch
var emptyLength = Ember.meta(store).descs ? undefined : 0;

var recordArray = store.peekAll('person');
run(function() {
Expand All @@ -125,7 +121,7 @@ test("stops updating when destroyed", function(assert) {
});

run(function() {
assert.equal(recordArray.get('length'), emptyLength, "Has no more records");
assert.equal(recordArray.get('length'), 0, "Has no more records");
store.push({
data: {
type: 'person',
Expand All @@ -137,11 +133,10 @@ test("stops updating when destroyed", function(assert) {
});
});

assert.equal(recordArray.get('length'), emptyLength, "Has not been updated");
assert.equal(recordArray.get('length'), 0, "Has not been updated");
assert.equal(recordArray.get('content'), undefined, "Has not been updated");
});


test("a loaded record is removed from a record array when it is deleted", function(assert) {
assert.expect(5);

Expand Down