Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Do not expose the array argument on store.query #4058

Merged
merged 1 commit into from
Jan 11, 2016
Merged

[BUGFIX beta] Do not expose the array argument on store.query #4058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addon/-private/system/record-arrays/record-array.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default Ember.ArrayProxy.extend(Ember.Evented, {
let query = get(this, 'query');

if (query) {
return store.query(modelName, query, this);
return store._query(modelName, query, this);
}

return store.findAll(modelName, { reload: true });
Expand Down
6 changes: 5 additions & 1 deletion addon/-private/system/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -955,7 +955,11 @@ Store = Service.extend({
@param {any} query an opaque query to be used by the adapter
@return {Promise} promise
*/
query(modelName, query, array) {
query(modelName, query) {
return this._query(modelName, query);
},

_query(modelName, query, array) {
assert('Passing classes to store methods has been removed. Please pass a dasherized string instead of '+ Ember.inspect(modelName), typeof modelName === 'string');
var typeClass = this.modelFor(modelName);
array = array || this.recordArrayManager
Expand Down