Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AMD dependencies #4214

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Fix AMD dependencies #4214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/babel-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
var babel = require('broccoli-babel-transpiler');
var path = require('path');
var moduleResolve = require('amd-name-resolver').moduleResolve;

function babelOptions(libraryName, _options) {
_options = _options || {};
Expand All @@ -20,12 +21,12 @@ function babelOptions(libraryName, _options) {
sourceMaps: false,
modules: 'amdStrict',
moduleRoot: libraryName,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

such plural

moduleId: true,
moduleIds: true,
// Transforms /index.js files to use their containing directory name
getModuleId: function (name) {
return name.replace(/\/index$/g, '');
},
resolveModuleSource: require('amd-name-resolver').moduleResolve
resolveModuleSource: moduleResolve
};

Object.keys(_options).forEach(function(opt) {
Expand Down