Add better error messaging for adapters that do not implement createR… #4283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmac
force-pushed
the
commit-assert
branch
2 times, most recently
from
6244659 to
c540b27
Compare
| @@ -562,7 +562,7 @@ Store = Service.extend({ | |||
| var adapter = this.adapterFor(typeClass.modelName); | |||
|
|
|||
| assert("You tried to find a record but you have no adapter (for " + typeClass + ")", adapter); | |||
| assert("You tried to find a record but your adapter (for " + typeClass + ") does not implement 'findRecord'", typeof adapter.findRecord === 'function' || typeof adapter.find === 'function'); | |||
| assert("You tried to find a record but your adapter (for " + typeClass + ") does not implement 'findRecord'", typeof adapter.findRecord === 'function'); | |||
|
This looks good. Do you think there should be tests for |
…ecord, updateRecord or deleteRecord.
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ecord, updateRecord or deleteRecord.