[BUGFIX beta] Fix resetting of properties to in-flight values #4379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dug up while working on #4246 |
| assert.equal(person.get('name'), "Tomathy"); | ||
|
|
||
| person.set('name', 'Thomas'); | ||
| assert.equal(person.get('name'), "Thomas"); |
There was a problem hiding this comment.
Without these 4 lines 131-135, this test passed without code changes. Changing name, and then changing it back, put the record in a bad state.
Changing the value of an in-flight property, then changing back, had the side effect that the record would be marked dirty once the save completed. `changedAttributes` would report that `name` had been changed from 'Thomas' to 'Thomas' This is because the attr computed was only checking to see if the value was being reset to the canonical value, not if it was being reset to the in-flight value
courajs
force-pushed
the
reset-to-inflight-value
branch
from
b729405 to
8046c48
Compare
|
Thanks @courajs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the value of an in-flight property, then changing back, had the
side effect that the record would be marked dirty once the save
completed.
changedAttributeswould report thatnamehad been changed from'Thomas' to 'Thomas'
This is because the attr computed was only checking to see if the value
was being reset to the canonical value, not if it was being reset to the
in-flight value