Naming cleanup #4601
Merged
Naming cleanup #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
force-pushed
the
feat/internal-model-round2
branch
2 times, most recently
from
2135379 to
6106341
Compare
runspired
force-pushed
the
feat/internal-model-round2
branch
from
6106341 to
196ca7a
Compare
runspired
force-pushed
the
feat/internal-model-round2
branch
from
4620406 to
73a3185
Compare
…ernalModel/record
|
I'm excited for this change. 🎉 |
pangratz
reviewed
Oct 24, 2016
| assert.expectAssertion(function() { | ||
| internalModel.materializeRecord(); | ||
| }, /more than once/); | ||
| }); |
There was a problem hiding this comment.
What's the reasoning behind removing this test?
There was a problem hiding this comment.
it's now impossible to trigger this assertion
There was a problem hiding this comment.
@pangratz I think internal model needs tests, but that's a separate PR, I removed this test because it's now not possible to materialize a record more than once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to enforce consistent use of