[BUGFIX beta] Inverse null relationships should throw if model doesn't exist 2 #4675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… at least in debug to avoid introducing potential bugs and display appropriate error messages. for performance those checks in prod should be disabled
|
This looks good to me. @runspired I would appreciate your eyes on this pr. |
|
@bmac will review this evening 👍 |
|
I forgot to come back and say that I reviewed and it looked good. @bmac |
|
Specifically, it does not affect or hinder any efforts at laziness, and is properly scoped to debug code paths. Any additional work to ensure laziness of relationship setup need not hold this up. |
|
@canufeel do you have time to rebase this pr? |
|
@bmac sure! Would spend some time on it in the next couple days. |
|
@bmac did a rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is continuation of #4558 which is closed in favour of this one.
2.6.0Introduced a bug such that for{ inverse: null }relationships the relationship target is not checked at model creation time. However without{ inverse: null }we would get an error when trying to create a model with relationship to another model that doesn't exist. This PR tries to bring in consistent behaviour for such cases - perform a check for model type during model creation and throw an error if the model is not present in the store.