es6 RecordArrayManager #4708

runspired · 2016-12-09T18:55:37Z

There wasn't really a good reason for this singleton being an Ember.Object (it's not resolved / not in the container / no ember-y things in use), and converting it shaves 33% off it's instantiation time in addition to giving us nice es6 syntax (1.53ms => .97ms).

I additionally moved the instantiation of the OrderedSet used to track the RecordArrays for an internalModel into internal models directly instead of having the manager reach in. I'm slightly conflicted on this because of the resulting double-underscore for the cached property, but I prefer to leave objects in control of their own properties.

Before

After

stefanpenner · 2016-12-09T19:19:36Z

This may be ok here. Although it is unclear if others don't reopen/extend this class. If that isn't the case, and the output isn't unreasonably large. This may be fine.

@runspired / @krisselden and myself should powow soon to fixup the cost centers insides of creation (of first object when mixins need application) in ember's core_object. I believe there is a relatively clear path to improving that, that would just have mega leverage across the whole ecosystem. I also believe this can be used to help bridge the ES6 <=> CoreObject worlds. As they really are not very dissimilar.

runspired · 2016-12-11T19:11:09Z

@stefanpenner this isn't something others can extend, but it is something that could theoretically have been reached into, found, and reopened. Is there a list of ember-data addons that we generally search for private usage in? cc @bmac

stefanpenner · 2016-12-12T01:53:38Z

tests/dummy/app/routes/query/route.js

@@ -24,6 +24,7 @@ export default Route.extend({
    let modelName = params.modelName;
    delete params.modelName;

+    console.time('ember-data');


^ should we leave this?

stefanpenner · 2016-12-12T01:53:55Z

tests/dummy/app/routes/query/route.js

@@ -33,6 +34,7 @@ export default Route.extend({
        // and clutter our benchmarks and make it harder to time.
        records.toArray();
        heimdall.stop(token);
+        console.timeEnd('ember-data');


^ should we leave this?

I've found it invaluable and it's in our dummy app so it should be ok.

however I also just want to bake this into heimdall.

stefanpenner · 2016-12-12T01:54:22Z

tests/unit/record-arrays/record-array-test.js

+  }
+
+  get _recordArrays() {
+    return this.__recordArrays;


who sets __recordArrays ?

perhaps no one at the moment, but our tests often introspect state so moving it to a similar getter will let us test correctly

ok, sounds good.

krisselden · 2016-12-12T04:40:23Z

(1.53ms => .97ms).

was this one sample?

krisselden · 2016-12-12T04:42:17Z

@stefanpenner didn't you reopen this at Yapp for the subscribe stuff?

krisselden · 2016-12-12T04:42:39Z

/cc @lukemelia

stefanpenner · 2016-12-12T04:46:07Z

@stefanpenner didn't you reopen this at Yapp for the subscribe stuff?

Unclear, I do also share your concern this is risky relative to the value. (making mixin stuff faster, would have nice leverage...)

krisselden · 2016-12-12T04:54:45Z

Also, the proto() is only doing work here because of lookupFactory extend.

runspired · 2016-12-12T13:42:52Z

As far as wins go, this one is pretty small, but one of hundreds of paper cuts we die from when out together.

I don't actually think the win here is in this small perf gain as much as it is in building a core set of primitives that don't depend on Ember unless they truly need to. If Ember.Object and lookupFactory do have their costs lowered, I'm still unconvinced that this would belong remaining one.

bmac · 2016-12-12T15:20:47Z

I just checked out the 47 Ember Data Adapter addons from ember observer into a directory and grepped for RecordArrayManager and found no matches. I think its unlikely that anyone is reopening the RecordArrayManager.

I've updated my search to include the https://emberobserver.com/categories/ember-data-extensions and still found nothing that references RecordArrayManager.

chadhietala · 2016-12-13T17:48:30Z

@runspired This great! Is there any way to get some more exhaustive benchmarks?

runspired · 2016-12-13T17:54:30Z

@chadhietala the benchmark runs for repeated iterations are roughly similar. Since we strip the classCallCheck I'd be surprised if the compiled output were larger vs equal or smaller than the compiled output for the Ember.Object version.

fivetanley · 2016-12-13T21:23:47Z

Would heavily prefer this to be feature flagged.

bmac · 2016-12-13T23:31:17Z

@fivetanley What is your thinking on why the feature flag for this change. In theory it should be invisible to users and doesn't provide and new functionality?

runspired · 2016-12-14T02:10:40Z

@bmac @fivetanley I think this is the sort of thing where if we send it out, and it breaks people's apps, its small and we just revert it. Don't think it warrants a flag.

runspired · 2017-01-12T14:55:11Z

cc @bmac @fivetanley for review and suggested next steps.

bmac · 2017-01-13T17:14:15Z

@runspired this just needs a rebase and should be good to merge.

runspired · 2017-01-13T19:00:19Z

@bmac rebased :)

stefanpenner reviewed Dec 12, 2016

View reviewed changes

runspired force-pushed the feat/es6-manager branch from c0f2de0 to 6bfa81a Compare December 13, 2016 18:05

bmac approved these changes Jan 13, 2017

View reviewed changes

es6 RecordArrayManager

d2b04f4

runspired force-pushed the feat/es6-manager branch from 6bfa81a to d2b04f4 Compare January 13, 2017 18:59

bmac merged commit ae4aa84 into emberjs:master Jan 13, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

es6 RecordArrayManager #4708

es6 RecordArrayManager #4708

runspired commented Dec 9, 2016 •

edited

Loading

stefanpenner commented Dec 9, 2016 •

edited

Loading

runspired commented Dec 11, 2016

stefanpenner Dec 12, 2016

stefanpenner Dec 12, 2016

runspired Dec 12, 2016

runspired Dec 12, 2016

stefanpenner Dec 12, 2016

stefanpenner Dec 12, 2016

runspired Dec 12, 2016

stefanpenner Dec 12, 2016

krisselden commented Dec 12, 2016

krisselden commented Dec 12, 2016

krisselden commented Dec 12, 2016

stefanpenner commented Dec 12, 2016

krisselden commented Dec 12, 2016

runspired commented Dec 12, 2016

bmac commented Dec 12, 2016 •

edited

Loading

chadhietala commented Dec 13, 2016

runspired commented Dec 13, 2016

fivetanley commented Dec 13, 2016

bmac commented Dec 13, 2016

runspired commented Dec 14, 2016 •

edited

Loading

runspired commented Jan 12, 2017

bmac commented Jan 13, 2017

runspired commented Jan 13, 2017

es6 RecordArrayManager #4708

es6 RecordArrayManager #4708

Conversation

runspired commented Dec 9, 2016 • edited Loading

stefanpenner commented Dec 9, 2016 • edited Loading

runspired commented Dec 11, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

krisselden commented Dec 12, 2016

krisselden commented Dec 12, 2016

krisselden commented Dec 12, 2016

stefanpenner commented Dec 12, 2016

krisselden commented Dec 12, 2016

runspired commented Dec 12, 2016

bmac commented Dec 12, 2016 • edited Loading

chadhietala commented Dec 13, 2016

runspired commented Dec 13, 2016

fivetanley commented Dec 13, 2016

bmac commented Dec 13, 2016

runspired commented Dec 14, 2016 • edited Loading

runspired commented Jan 12, 2017

bmac commented Jan 13, 2017

runspired commented Jan 13, 2017

runspired commented Dec 9, 2016 •

edited

Loading

stefanpenner commented Dec 9, 2016 •

edited

Loading

bmac commented Dec 12, 2016 •

edited

Loading

runspired commented Dec 14, 2016 •

edited

Loading