[DOC] Make model.unloadRecord public #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`store.unloadRecord` says that it's there for symmetry, meaning the model should have a similar public method.
bmac
reviewed
Jan 24, 2017
| @@ -587,8 +587,9 @@ const Model = Ember.Object.extend(Ember.Evented, { | |||
| }, | |||
|
|
|||
| /** | |||
| Unloads the record from the store. Only non-dirty records can be unloaded. | |||
There was a problem hiding this comment.
I'd remove the second sentence and add "This will cause the record to be destroyed and freed up for garbage collection.".
|
Should I update that on the store as well? |
knownasilya
added a commit
to knownasilya/data
that referenced
this pull request
Jan 24, 2017
See emberjs#4765 for reference
|
Thanks @knownasilya |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store.unloadRecordsays that it's there for symmetry, meaning the model should have a similar public method.cc @bmac