[PERF] Model.prototype.didDefineProperty only in dev #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
reviewed
Apr 14, 2017
| @@ -1924,4 +1884,47 @@ if (isEnabled('ds-rollback-attribute')) { | |||
| }); | |||
| } | |||
|
|
|||
| runInDebug(() => { | |||
| Model.reopen({ | |||
There was a problem hiding this comment.
I believe this should be reopenClass as this was a static method?
There was a problem hiding this comment.
actually scratch that I think I read the diff wrong on the original location.
|
|
|
@stefanpenner this is fixed by another of my PR's, the issue is that the env is "test" at runtime but "production" at build time, so our code stripping needs to take account a little differently. |
|
@stefanpenner actually, looks like you merged it: #4920 Try a rebase. |
9 tasks
`meta.parentType` (which is produced by) `didDefineProperty` is only required for development assertions. As development assertions are stripped in prod, this `didDefineProperty` can also be stripped
stefanpenner
force-pushed
the
strip-did-define-property
branch
from
60d5df8 to
23503f8
Compare
|
Also tidying up the other side of this in ember emberjs/ember.js#15141 (no cross dependencies exist) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meta.parentType(which is produced by)didDefinePropertyis only required for development assertions. As development assertions are stripped in prod, thisdidDefinePropertycan also be stripped