Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SVELTE] rollup -private for winnings #4925

Merged
merged 8 commits into from
Apr 25, 2017
Merged

[SVELTE] rollup -private for winnings #4925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
29408b7
refactor location of debug helpers to begin unlocking rollup of -private
runspired Apr 14, 2017
fa26447
refactor import/export pattern for model to improve isolation of -pri…
runspired Apr 14, 2017
f680345
privatize store, core, global, fix privatization of model
runspired Apr 14, 2017
e56866a
remove excess wiring from transforms
runspired Apr 14, 2017
9c5557c
unwinds 'features' (isEnabled) but hits a cycle
runspired Apr 14, 2017
24f4120
down to just circular refs and instance initializers
runspired Apr 14, 2017
1af1e21
ROLL'em UP
runspired Apr 14, 2017
f15c67b
fix build
runspired Apr 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,5 @@ node_modules/
bower_components/
.metadata_never_index
npm-debug.log

DEBUG-*
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,11 @@ production builds automatically.

Give it a default of `null` so it will not be used in production builds.

2. Import `isEnabled` from `ember-data/-private/features`, wrapping any new
2. Import `isEnabled` from `ember-data/-private`, wrapping any new
code with your feature:

```js
import isEnabled from 'ember-data/-private/features';
import { isEnabled } from 'ember-data/-private';

if (isEnabled('ds-mynew-feature')) {
// ... any additional code
Expand All @@ -99,7 +99,7 @@ production builds automatically.
feature flag.

```js
import isEnabled from 'ember-data/-private/features';
import { isEnabled } from 'ember-data/-private';

if (isEnabled('ds-mynew-feature')) {
test('test for new feature', function(assert) {
Expand Down
0 addon/-private/debug.js → addon/-debug/index.js
View file
Open in desktop
File renamed without changes.
Loading