[BUGFIX release] relationship [x, y] should not break on x.unloadRecord() #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complementary to: #4987
stefanpenner
force-pushed
the
release-unload-fun
branch
from
0a33215 to
c495d0b
Compare
|
@sudowork I have included your failing test (to ensure this does address the issue) |
Merged
|
👍 - This seems like a good path forward to me... |
hjdivad
approved these changes
Jul 25, 2017
| @@ -1645,6 +1727,37 @@ testInDebug('A sync hasMany errors out if there are unlaoded records in it', fun | |||
| }, /You looked up the 'comments' relationship on a 'post' with id 1 but some of the associated records were not loaded. Either make sure they are all loaded together with the parent record, or specify that the relationship is async \('DS.hasMany\({ async: true }\)'\)/); | |||
| }); | |||
|
|
|||
| testInDebug('After removing and unloading a record, a hasMany relationship should still be valid', function(assert) { | |||
| run(() => { | ||
| cars.get('firstObject').unloadRecord(); | ||
| // assert.equal(cars.get('length'), 1); // unload now.. | ||
| // assert.equal(person.get('cars.length'), 1); // unload now.. |
| Ember.run(() => { | ||
| tag.unloadRecord(); | ||
| assert.equal(people.get('isDestroying'), true); | ||
| assert.equal(people.get('isDestroyed'), false); | ||
| assert.equal(people.isDestroying, false, 'people is destroying sync after unloadRecord'); |
| assert.equal(people.get('isDestroyed'), false); | ||
| assert.equal(people.isDestroying, false, 'people is destroying sync after unloadRecord'); | ||
| assert.equal(people.isDestroyed, false, 'people is NOT YET destroyed sync after unloadRecord'); | ||
| assert.equal(peopleProxy.isDestroying, false, 'peopleProxy is destroying sync after unloadRecord'); |
| // assert.equal(person.get('cars.length'), 1); // unload now.. | ||
| }); | ||
|
|
||
| // assert.equal(cars.get('length'), 1); // unload now.. |
…rd() For an async relationship [x, y] with x.unloadRecord(), now adjusts only the relationship’s currentState, leaving that relationship’s canonical state alone, ensuring the existing client-side delete semantics are preserved. But when that relationship is reloaded, the canonicalState consulted. For sync relationship [x, y] with x.unloadRecord(), both currentState and canonical state are updated. This is to mirror the client-side delete semantics. But since we cannot reload a sync relationship we must assume this to be the new canonical state and rely on subsequent `push` or `adapterPayloads` or manual `store.push` to update. This aims to: * [FIX] hasMany arrays never contain dematerialized records (so they no longer become broken) * [FIX] using unloadRecord as a type of client side delete is restored * [PRESERVE] the garbage collector pass to cleanup orphaned models * [PRESERVE] second access to a relationship which did contain an unloadRecord to cause a reload note: if both sides of a relationships are unloaded, the above doesn’t apply. This is largely just when members of a loaded relationship are themselves unloaded. [fixes #4986 #5052 #4987 #4996]
stefanpenner
force-pushed
the
release-unload-fun
branch
from
c495d0b to
1eab76a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an async relationship [x, y] with x.unloadRecord(), now adjusts only the relationship’s currentState, leaving that relationship’s canonical state alone, ensuring the existing client-side delete semantics are preserved. But when that relationship is reloaded, the canonicalState consulted.
For sync relationship [x, y] with x.unloadRecord(), both currentState and canonical state are updated. This is to mirror the client-side delete semantics. But since we cannot reload a sync relationship we must assume this to be the new canonical state and rely on subsequent
pushoradapterPayloadsor manualstore.pushto update.This aims to:
note: if both sides of a relationships are unloaded, the above doesn’t apply. This is largely just when members of a loaded relationship are themselves unloaded.
[fixes #4986 #5052 #4987 #4996]