-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] remove all stale feature flags #5384
Conversation
Starting a list of tickets to update when this merges: |
@runspired sad about |
@jonnii are you saying you are using that feature!? Are you aware of |
@runspired I didn't realize |
Related: #5265 |
@runspired All green, so I guess this is good to merge ? Concerning the push-payload thing, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM...
@sly7-7 an example websocket push that is much less brittle than even the
|
As discussed in the face-to-face, our feature flags have gone very stale and we
we decided to go a different direction on each. This is a debt-collection PR to remove
our stale feature flags and reset the feature-flag clock.
All feature flags that were previously
null
were removed with theiroff
branch left behind.All feature flags that were previously
true
were removed with theiron
branch left behind.