Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] normalize model name for belongs to relationships #5477

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion addon/-private/system/relationship-meta.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,12 @@ export function typeForRelationshipMeta(meta) {
let modelName;

modelName = meta.type || meta.key;
modelName = normalizeModelName(modelName);

if (meta.kind === 'hasMany') {
modelName = singularize(normalizeModelName(modelName));
modelName = singularize(modelName);
}

return modelName;
}

Expand Down
50 changes: 50 additions & 0 deletions tests/unit/model/relationships-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,53 @@ test('eachRelatedType() iterates over relations without duplication', function(a

assert.deepEqual(relations, ['occupation', 'person']);
});

test('normalizing belongsTo relationship names', function(assert) {
const UserProfile = DS.Model.extend({
user: DS.belongsTo(),
});

let User = DS.Model.extend({
userProfile: DS.belongsTo(),
});

store = createStore({
user: User,
userProfile: UserProfile,
});

User = store.modelFor('user');

const relationships = get(User, 'relationships');

assert.ok(relationships.has('user-profile'), 'relationship key has been normalized');

const relationship = relationships.get('user-profile')[0];

assert.equal(relationship.meta.name, 'userProfile', 'relationship name has not been changed');
});

test('normalizing hasMany relationship names', function(assert) {
const StreamItem = DS.Model.extend({
user: DS.belongsTo(),
});

let User = DS.Model.extend({
streamItems: DS.hasMany(),
});

store = createStore({
user: User,
streamItem: StreamItem,
});

User = store.modelFor('user');

const relationships = get(User, 'relationships');

assert.ok(relationships.has('stream-item'), 'relationship key has been normalized');

const relationship = relationships.get('stream-item')[0];

assert.equal(relationship.meta.name, 'streamItems', 'relationship name has not been changed');
});