-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish docs to npm #5602
Publish docs to npm #5602
Conversation
@rwjblue @runspired looks like 3.4.0 docs didn't get published to s3. Can we merge this & get a patch version? |
.npmignore
Outdated
/node-tests | ||
/tests | ||
/tmp | ||
/bin | ||
/docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this still required if docs are now in dist/
?
So for what it does, this seems ok; however, I'm a bit confused as to why we now publish our docs on npm in this way (and why the emberjs website requires it). Does the S3 publishing no longer accomplish what the learning team needs? If so we should remove the S3 publishing. |
This is for building the API docs' search index.
I've modified the PR to remove the scripts for publishing yuidoc to s3 & to publish to npm instead |
* Publish yuidoc json file to npm * Remove the build step that publishes docs to s3
This is required to be on par with ember-source so that api docs can rely on using npm for fetching the yuidocs for >= 3.4.0 releases.