Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT fetch] use ember-fetch instead of jQuery #5626

Closed
wants to merge 6 commits into from

Conversation

NullVoxPopuli
Copy link
Contributor

Continuation of #5386

just trying to fix some tests.

@tchak I can point this at your branch as well if you want

/cc @runspired

@runspired
Copy link
Contributor

@NullVoxPopuli I'd open a PR to his branch as well

@NullVoxPopuli
Copy link
Contributor Author

tchak#2

@NullVoxPopuli
Copy link
Contributor Author

I think I fixed all the tests (at least locally).
I think there should probably be a good amount of tests for fetch, which don't exist yet.
also, with ember fetch, there is this function: mungOptionsForFetch

@runspired
Copy link
Contributor

@NullVoxPopuli failing linting atm

@NullVoxPopuli
Copy link
Contributor Author

Thanks! Updated

@tchak
Copy link
Member

tchak commented Sep 9, 2018

Thanks!

@NullVoxPopuli
Copy link
Contributor Author

closed, cause this was merged into @tchak 's branch :)

#5386

@NullVoxPopuli NullVoxPopuli deleted the use-fetch branch September 9, 2018 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants