[BUGFIX 5720] - assert that replacing has-many with non-array throws assertion #5721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbatson5
force-pushed
the
assert-replacing-has-many
branch
from
ab64536 to
e094db7
Compare
sbatson5
force-pushed
the
assert-replacing-has-many
branch
from
e094db7 to
9a5e2c3
Compare
runspired
approved these changes
Oct 26, 2018
There was a problem hiding this comment.
Overall this is awesome! Especial thanks for including the appropriate test.
I wish I weren't accepting an "old style" test (see any of the recent test cleanup PRs for examples of "new style", but given the number of tests in this file it seems best to me to leave it as is and refactor it with the rest of them in one go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5720
Assert that
objectsis an array or has array-like methods and return a more meaningful message when that condition is not met.