Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed small Docs and Code mismatches #5729

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Fixed small Docs and Code mismatches #5729

merged 2 commits into from
Nov 2, 2018

Conversation

spruce
Copy link
Contributor

@spruce spruce commented Oct 31, 2018 •
edited
Loading

As I was working on ember-api-docs I noticed some small missmatches between ED Api-docs and the actual implementation. Also EmberObject should also be referenced without a dot. I did fix these.

  • Also I notices that there is no Documentation for DS.Reference.
  • There is no Reference of all the uses of AdapterError in addon/-private/adapters/errors.js. Should I add them?

@igorT igorT merged commit c466ae8 into emberjs:master Nov 2, 2018
@igorT
Copy link
Member

igorT commented Nov 2, 2018 •
edited
Loading

Thanks for the doc fixes! I think adding the AdapterError uses would be great, and if you want to put a small doc for the Reference, saying that it is the baseClass for RecordReference/HasManyReference/BelongsToReference would be great as well

@spruce spruce mentioned this pull request Nov 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spruce @igorT