-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX release] Fixing adapter "Accept" header overwriting issue. #6062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makepanic
reviewed
Apr 24, 2019
makepanic
reviewed
Apr 24, 2019
runspired
approved these changes
Apr 24, 2019
Appears there is a linting error, but otherwise lgtm 👍 |
@runspired : Fixed the linting issues and pushed the code. Thanks, |
FYI - I'm labeling this as |
rwjblue
changed the title
Fixing adapter "Accept" header overwriting issue.
[BUGFIX release] Fixing adapter "Accept" header overwriting issue.
May 1, 2019
Fixing the bug that caused overwriting of "Accept" header in "ajaxOptions" method of the adapter.
I rebased and fixed the remaining linting issue. |
runspired
pushed a commit
that referenced
this pull request
May 1, 2019
[BUGFIX fetch] prevent Accept & ContentType header overwriting
runspired
pushed a commit
that referenced
this pull request
May 1, 2019
[BUGFIX fetch] prevent Accept & ContentType header overwriting
This was referenced May 1, 2019
Thanks! -nikhil. |
rwjblue
added a commit
that referenced
this pull request
May 1, 2019
[BUGFIX fetch] prevent Accept & ContentType header overwriting (#6062)
rwjblue
added a commit
that referenced
this pull request
May 1, 2019
[BUGFIX fetch] prevent Accept & ContentType header overwriting (#6062)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the bug that caused overwriting of "Accept" header in "ajaxOptions" method of the adapter. This is for addressing the issue #6058
Change description:
Updated the code in "packages\adapter\addon\json-api.js". If the input hash contains value for "Accept" header, it should not be overwritten by the default "application/vnd.api+json" string.
Added unit tests for checking this flow.
Fixes #6058