Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove remaining sinceToken and update docs #6168

Merged
merged 2 commits into from Jun 19, 2019
Merged

remove remaining sinceToken and update docs #6168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c9f1dd
remove documented use of sinceToken
eflanagan0 Jun 18, 2019
5ae6147
address feedback
eflanagan0 Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/adapter/addon/adapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,11 +130,10 @@ export default EmberObject.extend({
import $ from 'jquery';

export default DS.Adapter.extend({
findAll(store, type, sinceToken) {
let query = { since: sinceToken };
findAll(store, type) {

return new RSVP.Promise(function(resolve, reject) {
$.getJSON(`/${type.modelName}`, query).then(function(data) {
$.getJSON(`/${type.modelName}`).then(function(data) {
resolve(data);
}, function(jqXHR) {
reject(jqXHR);
Expand All @@ -147,7 +146,7 @@ export default EmberObject.extend({
@method findAll
@param {DS.Store} store
@param {DS.Model} type
@param {String} sinceToken
runspired marked this conversation as resolved.
Show resolved Hide resolved
@param {undefined} neverSet a value is never provided to this argument
@param {DS.SnapshotRecordArray} snapshotRecordArray
@return {Promise} promise
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/adapter/addon/rest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ const RESTAdapter = Adapter.extend(BuildURLMixin, {
@method findAll
@param {DS.Store} store
@param {DS.Model} type
@param {String} sinceToken
runspired marked this conversation as resolved.
Show resolved Hide resolved
@param {undefined} neverSet a value is never provided to this argument
@param {DS.SnapshotRecordArray} snapshotRecordArray
@return {Promise} promise
*/
Expand Down