[BUGFIX query] Remove arity check for adapter.query #6250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the issue described in #6232. The arity check that decides whether to create a record array and pass options to adapter.query fails when the adapter extends EmberObject.
runspired
approved these changes
Jul 15, 2019
pete-the-pete
pushed a commit
to pete-the-pete/data
that referenced
this pull request
Jul 23, 2019
This addresses the issue described in emberjs#6232. The arity check that decides whether to create a record array and pass options to adapter.query fails when the adapter extends EmberObject.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue described in #6232. The arity check that decides whether to create a record array and pass options to adapter.query when the adapter extends
EmberObject.The solution suggested by @runspired is to remove the arity check completely, so I took a stab at doing that.