fix: Strip Symbol from production builds

[dcyriller]

To ensure compatibility with IE11.

This should close #6380.

This implementation is taken from glimmer-vm. It is enumerable (as opposed to Symbol which is non-enumerable). But making it non-enumerable would come with a cost. And it will only be required for identifiers-related Symbols.

These remaining Symbols are still unpublished or behind a feature flag (not sure but they are not part of the build outputs). They are not included in this PR. As they'll require a more sophisticated approach to be specifically non-enumerable. As we said, I'll leave it to you @runspired.

[runspired]

As mentioned in the description, this doesn't change the Symbol usage for IS_IDENTIFIER on identifiers. I believe for that particular usage we do not want an enumerable symbol as we want to ensure ease of use and ease of serializability when handing them out to users (these other locations don't have this same constraint).

For IS_IDENTIFIER I suspect a weak-map lookup is what we want as more than likely that will be less expensive than defining a non-enumerable property, although I'm not 100% sure on this. cc @krisselden and @rwjblue for their thoughts on that.

[rwjblue]

For IS_IDENTIFIER I suspect a weak-map lookup is what we want as more than likely that will be less expensive than defining a non-enumerable property, although I'm not 100% sure on this. cc @krisselden and @rwjblue for their thoughts on that.

Ya, I agree. I'd go with a WeakMap (I'd probably also just always use the WeakMap and not have separate branches).

[dcyriller]

I’ll update symbol implementation with WeakMap very soon (incl. for identifiers related Symbols).

[dcyriller]

I've digged a bit and couldn't figure out how the WeakMap thing would look like. Could you give me another clue?

[rwjblue]

@dcyriller in general, the idea would be that instead of:

data/packages/store/addon/-private/ts-interfaces/identifier.ts

Line 4 in 63e13ba

export const IS_IDENTIFIER = Symbol('is-identifier');

data/packages/store/addon/-private/identifiers/cache.ts

Lines 418 to 423 in f472f27

	let recordIdentifier = {
	[IS_IDENTIFIER]: true as const,
	lid,
	id,
	type,
	};

data/packages/store/addon/-private/identifiers/is-stable-identifier.ts

Lines 7 to 9 in 63e13ba

	export default function isStableIdentifier(identifier: any): identifier is StableRecordIdentifier {
	return identifier[IS_IDENTIFIER] === true;
	}

You would do something akin to:

const IDENTIFIERS = new WeakMap();

export function isStableIdentifier(identifier) {
  return IDENTIFIERS.has(identifier);
}

export function markStableIdentifier(identifier) {
  IDENTIFIERS.set(identifier);
}