[DOC] Added documentation URL to evented deprecation warnings #6396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanmishkin
changed the title
yohanmishkin
changed the title
runspired
approved these changes
Sep 9, 2019
rwjblue
approved these changes
Sep 10, 2019
|
@yohanmishkin - Mind rebasing? We've fixed some bugs on master that should fix CI... |
yohanmishkin
force-pushed
the
tj/deprecation-warning-url
branch
2 times, most recently
from
5eaf8bc to
c204c4a
Compare
runspired
reviewed
Sep 19, 2019
| @@ -607,11 +607,15 @@ module('unit/model - Model', function(hooks) { | |||
| let record = store.createRecord('person'); | |||
|
|
|||
| record.on('event!', F); | |||
|
|
|||
| assert.expectDeprecation(/Called event! on person/); | |||
There was a problem hiding this comment.
this will need to be wrapped in an if (DEBUG)
runspired
reviewed
Sep 19, 2019
packages/serializer/addon/rest.js
Outdated
| @@ -286,8 +286,10 @@ const RESTSerializer = JSONSerializer.extend({ | |||
| 'The adapter returned an array for the primary data of a `queryRecord` response. This is deprecated as `queryRecord` should return a single record.'; | |||
|
|
|||
| deprecate(message, !isQueryRecordAnArray, { | |||
| id: 'ds.serializer.rest.queryRecord-array-response', | |||
| id: 'ember-data:store-queryrecord-array-response-with-restserializer', | |||
yohanmishkin
force-pushed
the
tj/deprecation-warning-url
branch
from
c204c4a to
d7e09ec
Compare
runspired
approved these changes
Sep 20, 2019
runspired
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6059 deprecation warnings for Evented usage we added. This PR adds a URL to the deprecation documentation for the console warnings.
before
after