[BUGFIX BETA RELEASE] ensure commit based versioning passes semver #6419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Sep 10, 2019
rwjblue
reviewed
Sep 10, 2019
runspired
force-pushed
the
bugfix/semver-commit-packages
branch
2 times, most recently
from
6b65bb9 to
c91d0be
Compare
rwjblue
approved these changes
Sep 10, 2019
runspired
force-pushed
the
bugfix/semver-commit-packages
branch
from
c91d0be to
bf7f0db
Compare
runspired
force-pushed
the
bugfix/semver-commit-packages
branch
from
bf7f0db to
d795598
Compare
This was referenced Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point recently
npminstalls began semver validating package versions. The versions we were producing for builds for individual commits failed validation because we required a-or+before the sha.Based on the precedence rules outlined here: https://github.com/semver/semver/blob/master/semver.md
I've updated our versioning from
x.x.x.<SHA>tox.x.x+sha.<SHA>for beta/canary branches the
-betaand-alphapre-release identifier will already be present