Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Return pushPayload result #6484

Closed
wants to merge 1 commit into from
Closed

[FEATURE] Return pushPayload result #6484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/serializer/addon/json-api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,11 @@ const JSONAPISerializer = JSONSerializer.extend({
@method pushPayload
@param {DS.Store} store
@param {Object} payload
@return the record(s) that was created or updated.
*/
pushPayload(store, payload) {
let normalizedPayload = this._normalizeDocumentHelper(payload);
store.push(normalizedPayload);
return store.push(normalizedPayload);
},

/**
Expand Down
3 changes: 2 additions & 1 deletion packages/serializer/addon/rest.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ const RESTSerializer = JSONSerializer.extend({
@method pushPayload
@param {DS.Store} store
@param {Object} payload
@return the record(s) that was created or updated.
*/
pushPayload(store, payload) {
let documentHash = {
Expand Down Expand Up @@ -414,7 +415,7 @@ const RESTSerializer = JSONSerializer.extend({
});
}

store.push(documentHash);
return store.push(documentHash);
},

/**
Expand Down
3 changes: 2 additions & 1 deletion packages/store/addon/-private/system/core-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2959,6 +2959,7 @@ abstract class CoreStore extends Service {
@method pushPayload
@param {String} modelName Optionally, a model type used to determine which serializer will be used
@param {Object} inputPayload
@return the record(s) that was created or updated
*/
pushPayload(modelName, inputPayload) {
if (DEBUG) {
Expand All @@ -2982,7 +2983,7 @@ abstract class CoreStore extends Service {
let normalizedModelName = normalizeModelName(modelName);
serializer = this.serializerFor(normalizedModelName);
}
serializer.pushPayload(this, payload);
return serializer.pushPayload(this, payload);
}

reloadManyArray(manyArray, internalModel, key, options) {
Expand Down