[TEST] - failing test to push records with async hasMany rel. after they have been destroyed on client-side

.eslintignore

@@ -4,6 +4,8 @@
 
 # compiled output
 **/dist/
+**/dist-control/
+**/dist-experiment/
 **/tmp/
 /packages/-ember-data/docs/
 

.eslintrc.js

@@ -1,13 +1,42 @@
+// See https://github.com/lydell/eslint-plugin-simple-import-sort#custom-grouping
+const ImportSortGroups = [
+  // Side effect imports.
+  // eslint-disable-next-line no-useless-escape
+  [`^\u0000`],
+  // Glimmer & Ember Dependencies
+  [`^(@ember/|@glimmer|ember$)`],
+  // Packages.
+  // Things that start with a letter (or digit or underscore), or `@` followed by a letter.
+  // But not our packages or packages starting with ember-
+  // eslint-disable-next-line no-useless-escape
+  [`^(?!@ember\-data)(?!ember-)(@?\\w)`],
+  // Packages starting with ember-
+  // eslint-disable-next-line no-useless-escape
+  [`^ember\-`],
+  // Our Packages.
+  // Things that start with @ember-data
+  // eslint-disable-next-line no-useless-escape
+  [`^@ember\-data`],
+  // Absolute imports and other imports such as Vue-style `@/foo`.
+  // Anything that does not start with a dot.
+  ['^[^.]'],
+  // Relative imports.
+  // Anything that starts with a dot.
+  // eslint-disable-next-line no-useless-escape
+  [`^\.`],
+];
+
 module.exports = {
   parser: 'babel-eslint',
   root: true,
   parserOptions: {
     ecmaVersion: 2017,
     sourceType: 'module',
   },
-  plugins: ['prettier', 'qunit', 'mocha'],
-  extends: ['eslint:recommended', 'prettier'],
+  plugins: ['prettier', 'qunit', 'mocha', 'simple-import-sort', 'import'],
+  extends: ['eslint:recommended', 'prettier', 'plugin:qunit/recommended'],
   rules: {
+    'no-restricted-globals': ['error', { name: 'Promise', message: 'Global Promise does not work in IE11' }],
     'mocha/no-exclusive-tests': 'error',
     'prettier/prettier': 'error',
     'no-unused-vars': ['error', { args: 'none' }],
@@ -18,16 +47,33 @@ module.exports = {
     'no-caller': 'error',
     'no-eq-null': 'error',
     'no-console': 'error', // no longer recommended in eslint v6, this restores it
+    'simple-import-sort/sort': ['error', { groups: ImportSortGroups }],
+    'sort-imports': 'off',
+    'import/order': 'off',
+    'import/first': 'error',
+    'import/newline-after-import': 'error',
+    // this rule doesn't work properly with --fix
+    // https://github.com/benmosher/eslint-plugin-import/issues/1504
+    'import/no-duplicates': 'warn',
 
     // Too many false positives
     // See https://github.com/eslint/eslint/issues/11899 and similar
     'require-atomic-updates': 'off',
+
+    // eslint-plugin-qunit
+    'qunit/assert-args': 'off',
+    'qunit/literal-compare-order': 'off',
+    'qunit/no-identical-names': 'off',
+    'qunit/no-ok-equality': 'off',
+    'qunit/require-expect': 'off',
+    'qunit/resolve-async': 'off',
   },
   globals: {
     heimdall: true,
     Map: false,
     WeakMap: true,
     Set: true,
+    Promise: false,
   },
   env: {
     browser: true,
@@ -41,12 +87,21 @@ module.exports = {
       parserOptions: {
         sourceType: 'module',
       },
-      plugins: ['@typescript-eslint'],
+      plugins: ['@typescript-eslint', 'ember-data', 'simple-import-sort', 'import'],
       extends: ['eslint:recommended', 'plugin:@typescript-eslint/eslint-recommended'],
       rules: {
         '@typescript-eslint/no-unused-vars': ['error', { args: 'none' }],
         'no-unused-vars': 'off',
         'require-atomic-updates': 'off',
+        'ember-data/prefer-type-only-import': 'error',
+        'simple-import-sort/sort': ['error', { groups: ImportSortGroups }],
+        'sort-imports': 'off',
+        'import/order': 'off',
+        'import/first': 'error',
+        'import/newline-after-import': 'error',
+        // this rule doesn't work properly with --fix
+        // https://github.com/benmosher/eslint-plugin-import/issues/1504
+        'import/no-duplicates': 'warn',
       },
     },
 
@@ -56,9 +111,10 @@ module.exports = {
         '.mocharc.js',
         '.eslintrc.js',
         '.prettierrc.js',
-        'bin/*',
-        'packages/-build-infra/src/**/*.js',
-        'packages/-test-infra/src/**/*.js',
+        'bin/**',
+        'packages/private-build-infra/src/**/*.js',
+        'packages/unpublished-test-infra/src/**/*.js',
+        'packages/unpublished-eslint-rules/src/**/*.js',
         'packages/*/.ember-cli.js',
         'packages/*/.eslintrc.js',
         'packages/*/.template-lintrc.js',
@@ -85,16 +141,27 @@ module.exports = {
         node: true,
         es6: true,
       },
-      plugins: ['node'],
+      plugins: ['node', 'import'],
       extends: 'plugin:node/recommended',
+      rules: {
+        'simple-import-sort/sort': 'off',
+        'no-restricted-globals': 'off',
+        'import/first': 'error',
+        'import/newline-after-import': 'error',
+        'import/no-duplicates': 'error',
+        'import/order': ['error', { 'newlines-between': 'always' }],
+      },
     },
 
     // node tests
     {
-      files: ['packages/*/node-tests/**', 'packages/-test-infra/src/node-test-helpers/**/*'],
+      files: ['packages/*/node-tests/**', 'packages/unpublished-test-infra/src/node-test-helpers/**/*'],
       env: {
         mocha: true,
       },
+      rules: {
+        'no-restricted-globals': 'off',
+      },
     },
 
     // docs
@@ -104,16 +171,20 @@ module.exports = {
         qunit: true,
         es6: false,
       },
+      rules: {
+        'no-restricted-globals': 'off',
+      },
     },
 
     // bin files
     {
-      files: ['bin/*'],
+      files: ['bin/**'],
       // eslint-disable-next-line node/no-unpublished-require
       rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
         'no-console': 'off',
         'no-process-exit': 'off',
         'node/no-unpublished-require': 'off',
+        'node/no-unsupported-features/node-builtins': 'off',
       }),
     },
   ],

.github/ISSUE_TEMPLATE.md

@@ -23,7 +23,7 @@ If a previous version of `ember-data` worked as `expected`, which was the most r
 
 ### Versions
 
-Run the following command and paste the output below: `npm ls ember-source && npm ls ember-cli && npm ls ember-data`.
+Run the following command and paste the output below: `yarn list ember-source && yarn list ember-cli && yarn list --pattern ember-data`.
 
 ```cli
 [Replace this line with the output]

.github/workflows/asset-size-check.yml

@@ -0,0 +1,114 @@
+name: AssetSizeCheck
+
+on:
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  asset-size-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v1
+        with:
+          fetch-depth: 0
+      - uses: actions/setup-node@v1
+        with:
+          node-version: 12.x
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
+      - name: Check SHA
+        run: |
+          sha=$(git rev-parse --short=8 HEAD)
+          echo "HEAD sha=$sha"
+          echo "GITHUB_SHA sha=$GITHUB_SHA"
+          mkdir -p tmp
+          echo $sha > tmp/sha-for-check.txt
+          originSha=$(git rev-parse HEAD^2)
+          echo $originSha > tmp/sha-for-commit.txt
+          git show --format=short --no-patch $originSha
+      - name: Checkout master
+        run: git checkout master
+      - name: Install dependencies for master
+        run: yarn install
+      - name: Build Production master (IE11)
+        run: |
+          mkdir -p packages/-ember-data/dists
+          EMBER_DATA_FULL_COMPAT=true TARGET_IE11=true yarn workspace ember-data ember build -e production --output-path dists/control-ie11
+      - name: Build Production master
+        run: EMBER_DATA_FULL_COMPAT=true yarn workspace ember-data ember build -e production --output-path dists/control
+      - name: Build Production master (no rollup)
+        run: EMBER_DATA_FULL_COMPAT=true EMBER_DATA_ROLLUP_PRIVATE=false yarn workspace ember-data ember build -e production --output-path dists/control-no-rollup
+      - name: Checkout ${{github.ref}}
+        run: |
+          sha=$(cat tmp/sha-for-check.txt)
+          git checkout --progress --force $sha
+      - name: Install dependencies for ${{github.ref}}
+        run: yarn install
+      - name: Build Production ${{github.ref}} (IE11)
+        run: EMBER_DATA_FULL_COMPAT=true TARGET_IE11=true yarn workspace ember-data ember build -e production --output-path dists/experiment-ie11
+      - name: Build Production ${{github.ref}}
+        run: EMBER_DATA_FULL_COMPAT=true yarn workspace ember-data ember build -e production --output-path dists/experiment
+      - name: Build Production ${{github.ref}} (no rollup)
+        run: EMBER_DATA_FULL_COMPAT=true EMBER_DATA_ROLLUP_PRIVATE=false yarn workspace ember-data ember build -e production --output-path dists/experiment-no-rollup
+      - name: Analyze Master Assets (IE11)
+        run: |
+          node ./bin/asset-size-tracking/generate-analysis.js packages/-ember-data/dists/control-ie11 ./control-ie11-data.json
+          mkdir -p tmp
+          mkdir -p tmp/asset-sizes
+          node ./bin/asset-size-tracking/print-analysis.js ./control-ie11-data.json -show > tmp/asset-sizes/master-analysis-ie11.txt
+      - name: Analyze Master Assets
+        run: |
+          node ./bin/asset-size-tracking/generate-analysis.js packages/-ember-data/dists/control ./control-data.json
+          node ./bin/asset-size-tracking/print-analysis.js ./control-data.json -show > tmp/asset-sizes/master-analysis.txt
+      - name: Analyze Master Assets (no rollup)
+        run: |
+          node ./bin/asset-size-tracking/generate-analysis.js packages/-ember-data/dists/control-no-rollup ./control-data-no-rollup.json
+          node ./bin/asset-size-tracking/print-analysis.js ./control-data-no-rollup.json -show > tmp/asset-sizes/master-analysis-no-rollup.txt
+      - name: Analyze ${{github.ref}} Assets (IE11)
+        run: |
+          node ./bin/asset-size-tracking/generate-analysis.js packages/-ember-data/dists/experiment-ie11 ./experiment-ie11-data.json
+          node ./bin/asset-size-tracking/print-analysis.js ./experiment-ie11-data.json > tmp/asset-sizes/experiment-analysis-ie11.txt
+      - name: Analyze ${{github.ref}} Assets
+        run: |
+          node ./bin/asset-size-tracking/generate-analysis.js packages/-ember-data/dists/experiment ./experiment-data.json
+          node ./bin/asset-size-tracking/print-analysis.js ./experiment-data.json > tmp/asset-sizes/experiment-analysis.txt
+      - name: Analyze ${{github.ref}} Assets
+        run: |
+          node ./bin/asset-size-tracking/generate-analysis.js packages/-ember-data/dists/experiment-no-rollup ./experiment-data-no-rollup.json
+          node ./bin/asset-size-tracking/print-analysis.js ./experiment-data-no-rollup.json > tmp/asset-sizes/experiment-analysis-no-rollup.txt
+      - name: Test Asset Sizes (IE11)
+        run: |
+          set -o pipefail
+          node ./bin/asset-size-tracking/generate-diff.js ./control-ie11-data.json ./experiment-ie11-data.json | tee tmp/asset-sizes/diff-ie11.txt
+      - name: Test Asset Sizes
+        if: failure() || success()
+        run: |
+          set -o pipefail
+          node ./bin/asset-size-tracking/generate-diff.js ./control-data.json ./experiment-data.json | tee tmp/asset-sizes/diff.txt
+      - name: Test Asset Sizes
+        if: failure() || success()
+        run: |
+          # we don't set -o pipefail as this should always pass, we just want the diff
+          node ./bin/asset-size-tracking/generate-diff.js ./control-data-no-rollup.json ./experiment-data-no-rollup.json | tee tmp/asset-sizes/diff-no-rollup.txt
+      - name: Upload Dist Artifacts
+        if: failure() || success()
+        uses: actions/upload-artifact@v1
+        with:
+          name: dists
+          path: packages/-ember-data/dists
+      - name: Upload Report Artifacts
+        if: failure() || success()
+        uses: actions/upload-artifact@v1
+        with:
+          name: reports
+          path: tmp/asset-sizes
+      - name: Report Asset Sizes
+        if: failure() || success()
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          COMMENT_MARKER="Asset Size Report for "
+          sha=$(cat tmp/sha-for-commit.txt)
+          node ./bin/asset-size-tracking/src/create-comment-text.js $sha > tmp/asset-sizes/comment.txt
+          COMMENT_TEXT="@./tmp/asset-sizes/comment.txt"
+          source bin/asset-size-tracking/src/post-comment.sh