-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump typescript from 3.6.4 to 3.7.2 #6682
Conversation
6384f72
to
cd6c3d6
Compare
@mike-north @chriskrycho safe to do? |
because types are being stripped before publish, changing the TS version will not affect consumers of ember-data. However, given that the 3.7 stable release was published yesterday, I'd worry a little about this causing extra work for contributors. As of late last week, things like prettier and ESLint hard failed around some of the new things that come in 3.7 like optional chaining and |
Concur with Mike. Prettier has support on master but as of this morning hadn’t cut a release. I’d give it a week or so and reevaluate. |
6ddf844
to
2910377
Compare
8f3600f
to
bd76329
Compare
010bd94
to
d273d34
Compare
Asset Size Report for d273d34 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
53143e5
to
b3007fd
Compare
ff19505
to
1c65187
Compare
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.6.4 to 3.7.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
1c65187
to
b742612
Compare
Asset Size Report for b742612 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
We've bumped to the prettier version with the associated fixes, and the typescript-eslint version as well. Going to land this now. |
One note to watch out for: 3.7.2 had some serious bugs around its new features; the `declare` syntax for class properties types emits literally the opposite of what it should. 🤦🏻♂️ So: don’t use `declare` yet, and you’ll want to bump to 3.7.3 as soon as they release it.
|
Bumps typescript from 3.6.4 to 3.7.2.
Release notes
Sourced from typescript's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will not automatically merge this PR because it includes an out-of-range update to a development dependency.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: