-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHORE] build speed improvements & docs path fix #6734
Conversation
Asset Size Report for b67f0c3 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
Asset Size Report for 85da8e7 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
Asset Size Report for 217e298 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
@@ -252,5 +252,15 @@ module.exports = { | |||
'pushPayload [OPTIONAL]', | |||
'serializeIntoHash [OPTIONAL]', | |||
'normalize [OPTIONAL]', | |||
'columnNameToDesc', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What caused this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing the inclusion of the debug
package, there is a follow up PR to this on that will make our tests and fixtures show the module, class, package and public/private status of each piece of API documentation so that "why" something changes is more clear.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add that to the PR description please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -11,14 +11,14 @@ | |||
"build": "ember build", | |||
"build:production": "ember build --environment=production", | |||
"start": "ember server", | |||
"docs": "ember ember-cli-yuidoc", | |||
"docs": "mkdir -p dist && ember ember-cli-yuidoc", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work correctly if you already have stuff in dist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the -p
flag does this:
The -p will create the directory(along with the directories that lead to the directory you want to create) and would ignore any errors if the directory already exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant more from there being existing code inside the folder, vs just the folder itself
Asset Size Report for 6be9b95 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
Asset Size Report for fbf06f8 EmberData has not changed in sizeIf any packages had changed sizes they would be listed here. Changeset
Full Asset Analysis
|
record-data
anddebug
packages to the docs generation scriptNote we weren't publishing any of the built artifacts other than one docs file already
.npmignore